+3

Log, Filter: improve search for 'Content' in files performance

Maciej Andrzejewski 2 years ago updated by fourier 8 months ago 5

Better search for 'Content' in files.

This feature basicaly works but it is not usable in most of time so I have to fallback to command line and user 'git grep' to find what I need *in seconds*.

The way I use it now:

In the log screen I type searched string and check the 'Content' type.

The commits are being searched and now there are two problems:

First problem: The 'Files' view will not get filled/updated with searched data until whole repository search is completed. In big repositories that means I will never get the results and can wait for ages. Using 'git grep' I complete this part in seconds. It would be great to have *a button to stop searching* for commits and start analyzing the 'Files' output.

I wonder if this feature is in any interest of the SmartGit's developers group?

First problem: by default, SmartGit tries to build a graph of the filtered commits. This requires to look-ahead. Is responsiveness better when unselecting "Show Graph While Filtering"?

Second problem split off to https://smartgit.userecho.com/communities/1/topics/1500-

Vote for this feature, fast visual git grep with ability to open file with internal and (using command line) in external editor could be a fantastic feature.

Still waiting for this feature, graphical "git grep"

From UX point of view, I could imagine it the same way as we have the Files view: a window with a list of found files with occurences and lines, and the view window(similar to Changes diff view now). The user shall be able to navigate the search results with arrows and see the contents in the View window, the same way as we can now with i.e. Modified files. The Enter key on search results window should show the View; an alternative command pattern shall be available to launch the external editor with file path and line number command line arguments.