+3
Started

"Finish feature" in git flow should push dev branch

Aurelijus Rožė 4 years ago updated by Marc Strapetz 1 year ago 5

Some git flow operations (hotfix finish, release finish) push master and dev branches to origin, but Finish feature does not. I found myself self several time having not pushed dev branch as I expected Finish feature will do all steps required.

Under review

I'm not sure why (nvie's) Git-Flow is working differently for features than for hotfixes or releases. I can only speculate and this is what makes sense to me: features are usually larger changes and despite of a successful merge/rebase of your feature onto develop, you might still want to perform some more tasks before finally pushing, like checking whether everything still compiles or running tests.

+1

This is good argument but on the other hand standard practice is to merge dev to feature branch and test it there before merging feature to dev. So when finishing the feature you know everything is working and can just merge and push.

+1

This could be added as an option right ?

This seems to be equivalent to Git-Flow AVH option "gitflow.feature.finish.push" and will be implemented as part of  https://smartgit.userecho.com/communities/1/topics/409-