0
Under review

Do not disable the Changes button when not necessary

Peter Slížik 4 weeks ago • updated by Thomas Singer 4 weeks ago 1

1. Log window: Select two commits (click, then ctrl+click).

2. The Changes button in the toolbar (F4) is disabled. (Why? Am I prohibited to make a diff at this moment? This is illogical.)

3. Click anywhere inside of one of the diff widgets. Now the Changes button becomes active. (It should have been active in step 2.)

Note: The button tooltip reads: "Show local changes. F4" I think the word local is superfluous here. We can't show remote changes anyway, any remote data are first downloaded to the local computer by git. Does it mean "Show changes to the working directory?" No, it can be used to show a diff between any two commits. I think "Show changes. F4" or "Show a diff. F4" should be enough.

Under review

Explanation: SmartGit always is very sensitive to what control has the focus and what is selected. The Query | Show Changes menu item (= toolbar button) requires the focus in the Files view and a single selection there.
We could relax this a little bit to not require the focus in the Files view.