0
Completed
Discard: "Discard to Stash" button should not be the default
When discarding changes, the highlighted button is "Discard to stash". I think it would be a better choice to highlight "Discard" and switch button positions, as it's very misleading. I don't know for others, but when I want to stash files, I use the corresponding action, and when I want to discard things, I want to... discard things.
Having the option to stash instead of discarding is a good idea, but it definitively should not be considered as "default"
GOOD, I'M SATISFIED
Thanks !
The stash tree is not my trash bin :)
Satisfaction mark by mtancoigne 4 years ago
Customer support service by UserEcho
It became the default because it is some kind of 'move to trash' instead of 'delete physically' - it's safer. Maybe we can add some low-level property to make the Discard to the default.
"discard.safeDefault" is the low-level property name.
Doesn't work :(
The button is still in the wrong location, and hitting enter doesn't press it even though it shows the highlight.
I also believe the default is wrong, I always get annoyed when applications don't do what I tell them to and have a mind of their own.
The property configuration works for me.
sg_nodiscard.mov
Wow - so glad this option has been added. I have ctrl-z+enter so firmly fixed in my muscle memory - it was becoming very annoying accidentally creating stashes all the time.
Also very annoyed by this change. If I say discard why would the application do stash instead? If I want to stash I say stash. Now CTRL+S and CTRL+Z do the same thing.
Even with the option enabled, i still find myself accidentally clicking the button on the right
Can we have an option to move the discard button to its original position, before this discard to stash button was a thing?
We have a slight option/low-level-properties inflation in SmartGit. Hence following suggestion:
Change "discard.safeDefault" to simply hide the "Discard to Stash" button entirely
@all, any objections?
Reasonable. I rarely use the Discard to Stash.
I'd be okay with that too, thx.
For the next build, there will be "discard.showStashOption" instead of "discard.safeDefault"; if "smartgit.discard.safeDefault" is still present in your smartgit.properties, it will still be used as default value for the new option.